refactor: extract shared read_error_body helper for upload providers - #5
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
refactor: extract shared read_error_body helper for upload providers#5devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every storage-provider upload module (
local,onedrive,qiniu,s3,upyun) repeated the same two lines on the HTTP error path to pull the status and body out of a failed response:This centralizes that into one shared helper so the "best-effort read, empty string on decode failure" decision lives in a single place.
New
crates/cloudreve-sync/src/uploader/providers/http.rs:Each provider's error branch now reads:
Applied to 9 call sites across the 5 provider files. The provider-specific error parsing/formatting (
format_s3_error,QiniuError,UpyunError,OneDriveError, etc.) is left exactly as-is — only the extraction boilerplate is deduplicated, so behavior is unchanged.Added two
wiremock-backed unit tests covering the populated-body and empty-body cases.Testing
cargo test -p cloudreve-sync— all pass (including the 2 new tests)cargo clippy -p cloudreve-sync— no new warnings introducedLink to Devin session: https://app.devin.ai/sessions/0f3275d1c9ef4100b2eb4ac3bfab22fe
Requested by: @cedev-1