feat: Refactor cacct app to configure TSDB custom queries - #585
Merged
Conversation
* This commit adds support to configure custom instant queries to TSDB so that users that need metrics other than the ones stored in API server can be queried and saved to CSV. * The internal TSDB client has been refactored to return result vectors for instant queries to keep all the labels in the results. Consequently TSDB updater has been refactored to fetch UUID from the result vectors before adding them to unit models * cacct config has been modified to add new instant and range queries along with their names and help text so that it will be added to the end users' metrics file for better comprehension * Unnecessary labels will be stripped from TS data for the end users * Updated e2e tests and new tests to verify the added functionalities Signed-off-by: Mahendra Paipuri <mahendra.paipuri@gmail.com>
mahendrapaipuri
added
enhancement
Signed-off-by: Mahendra Paipuri <mahendra.paipuri@gmail.com>
* Chunk based on available samples in the instant queries of cacct * Update docs and tests Signed-off-by: Mahendra Paipuri <mahendra.paipuri@gmail.com>
Signed-off-by: Mahendra Paipuri <mahendra.paipuri@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support to configure custom instant queries to TSDB so that users that need metrics other than the ones stored in API server can be queried and saved to CSV.
The internal TSDB client has been refactored to return result vectors for instant queries to keep all the labels in the results. Consequently TSDB updater has been refactored to fetch UUID from the result vectors before adding them to unit models
cacct config has been modified to add new instant and range queries along with their names and help text so that it will be added to the end users' metrics file for better comprehension
Unnecessary labels will be stripped from TS data for the end users
Updated e2e tests and new tests to verify the added functionalities
Closes #557