Skip to content

[Pratt Parser] Inline the ParsePrimary function #2163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jul 24, 2026
+4 −2
Merged

[Pratt Parser] Inline the ParsePrimary function #2163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions parser/internal/pratt_parser_worker.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
#include <utility>
#include <vector>

#include "absl/base/attributes.h"
#include "absl/base/nullability.h"
#include "absl/base/optimization.h"
#include "absl/container/flat_hash_map.h"
Expand Down Expand Up @@ -257,7 +258,7 @@ class PrattParserWorker : public ParserWorker {
// Example (`(a + b)`): Consumes `(`, recurses to `ParseExpr()`, and expects
// `)`. Example (`has(x.y)`): Consumes `has`, parses arguments `(x.y)`, and
// expands the `has` macro.
ExprNode ParsePrimary();
ABSL_ATTRIBUTE_ALWAYS_INLINE inline ExprNode ParsePrimary();

ExprNode ParseList();
ExprNode ParseMap();
Expand Down Expand Up @@ -621,7 +622,8 @@ ExprNode PrattParserWorker<ExprNode>::ParseIdentOrCall() {
// (`[...]`, `{...}`), and identifiers/global function calls (`foo`,
// `has(x.y)`).
template <typename ExprNode>
ExprNode PrattParserWorker<ExprNode>::ParsePrimary() {
ABSL_ATTRIBUTE_ALWAYS_INLINE inline ExprNode
PrattParserWorker<ExprNode>::ParsePrimary() {
ExprNode expr;
TokenType tok_type = peek_token_.type;
if (tok_type == TokenType::kLeftParen) {
Expand Down
Loading