Skip to content

SP-45: Add asset-registry schema, examples, methodology commands#341

Merged
Zgjim Haziri (ZgjimHaziri) merged 3 commits intomainfrom
SP-39-add-asset-registry-proxy-commands
Apr 17, 2026
Merged

SP-45: Add asset-registry schema, examples, methodology commands#341
Zgjim Haziri (ZgjimHaziri) merged 3 commits intomainfrom
SP-39-add-asset-registry-proxy-commands

Conversation

@ZgjimHaziri
Copy link
Copy Markdown
Contributor

@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) commented Apr 16, 2026

Description

Add dedicated asset-registry subcommands for fetching schemas, examples, and methodology — replacing the beta api request command that required manual URL construction.

New commands:

  • asset-registry schema --assetType X [--json]
  • asset-registry examples --assetType X [--json]
  • asset-registry methodology --assetType X [--json]

These hit the new Pacman proxy endpoints added in celonis/pacman#1646, so callers no longer need to resolve descriptor paths themselves.

The api beta command is removed — it's fully superseded by these commands.

The agentic development guide, Cursor skill, and command docs are updated accordingly.

Relevant links

Checklist

  • I have self-reviewed this PR
  • I have tested the change and proved that it works in different scenarios
  • I have updated docs if needed

AI

Includes-AI-Code: true

Made with Cursor

Replace the beta `api request` command with dedicated asset-registry
subcommands that hit the new Pacman proxy endpoints:

- `asset-registry schema --assetType X`
- `asset-registry examples --assetType X`
- `asset-registry methodology --assetType X`

Remove the `api` command — no longer needed now that schema, examples,
and methodology are accessible through first-class commands.

Update the agentic development guide, Cursor skill, and command docs.

Includes-AI-Code: true
Made-with: Cursor
@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) requested a review from a team as a code owner April 16, 2026 12:52
@Buqeta
Copy link
Copy Markdown
Contributor

Let's not forget to add the validate command too. The PR to add it in Pacman is open.

Comment thread .cursor/skills/asset-registry-endpoints/SKILL.md
Comment thread .cursor/skills/asset-registry-endpoints/SKILL.md Outdated
- SKILL.md: Instruct agents to check validation results before importing
  and prompt the user if validation fails (promeris feedback)
- Fix "500 on import" to "Errors on import (400 / 500)" in skill and
  guide (promeris feedback)
- Add module-level tests for asset-registry handlers to improve coverage

Includes-AI-Code: true
Made-with: Cursor
Includes-AI-Code: true
Made-with: Cursor
@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) force-pushed the SP-39-add-asset-registry-proxy-commands branch from 863f434 to 0bb130a Compare April 17, 2026 13:27
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
75.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@ZgjimHaziri
Copy link
Copy Markdown
Contributor Author

Removed the validate command, since it turned out to be more complicated than thought first. Considering it's not the priority right now, will proceed with the other commands to unblock testing.

@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) merged commit 528b919 into main Apr 17, 2026
5 of 6 checks passed
@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) deleted the SP-39-add-asset-registry-proxy-commands branch April 17, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants