fix: redact runtime repository credentials#2220
Open
immanuwell wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny fix for YAML output:
runtime_repositorieswas missing the same URL redaction path used byrepositoriesandbuild_repositories.Repro was pretty direct:
go test ./pkg/build/types -run TestYamlMarshallingRepositories -count=1Before this, a runtime-only repo like
https://user:pass@...marshalled withpassstill visible. Kinda yikes. Now it comes out ashttps://user:xxxxx@..., same as the other repo fields.Checked:
go test ./pkg/build/types -count=1No related issue/PR found via
ghsearch.