Conversation
linter-service1 of 7 selected linter(s) reported issues or failed; 1 additional linter(s) reported warnings.
Show checked targets for rustfmtTarget file paths:
Show checked targets for cargo-clippyTarget file paths:
Cargo project targets:
Show checked targets for cargo-denyTarget file paths:
Cargo project targets:
Show checked targets for cargo-couplingTarget file paths:
Cargo project targets:
Show checked targets for cargo-symbol-lengthTarget file paths:
Cargo project targets:
Show checked targets for taploTarget file paths:
Show checked targets for editorconfig-checkerTarget file paths:
Show details for 2 linter(s) with warnings or failurescargo-denycargo-coupling |
- contract/core/src/lib.rs: ConsoleCore trait, GpuCommand enum, GpuCommandList, CoreConfig, CoreCapabilities, VideoSignalKind, EmuCommand enum, CoreError, AudioBackend/Device/DeviceKind/PortIo traits(仮置き、Phase 3/4で移動) - Cargo.toml: members, default-members, workspace dependency pathをcore/→nes/core/に更新 - git mv core/ nes/core/: ディレクトリ移動 - nerust_core → nerust_nes_core: パッケージ名変更、全使用箇所を一括置換 cargo test: 155 passed, 0 failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
変更内容
contract/core に型定義を追加
nerust_screen_video(FrameBuffer),thiserrorcore/ → nes/core/ 移動
nes/core/に移動nerust_coreは変更なし(use 文の修正不要)確認