Allow overriding Python version when calling the opsqueue_python Nix package#96
Open
Allow overriding Python version when calling the opsqueue_python Nix package#96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, if e.g. a user of the Nix Python package builds their own python that is separate from
pkgs.python3(e.g. rather than overriding that one in an overlay, they create a separate one), it is likely that the resulting wheel / compiled FFI module is not placed in the right location, which makes the build fail (at the 'can I find all the imports' step).This PR fixes that, by adding
python = ...to the parameters ofopsqueue_python.nixmeaning that a user can docallPackage "......./opsqueue_python.nix" { python = myOtherPython; };and be merry.