Update alias uniqueness for contributor aliases#288
Merged
Conversation
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
cdolfi
approved these changes
May 5, 2026
Contributor
cdolfi
left a comment
cdolfi
left a comment
There was a problem hiding this comment.
lgtm! relatively straightforward fix and sufficient testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #273 by introducing a database migration to update the Unique constraint for contributor alias emails to cover the contributor id as well.
Notes for Reviewers
This was tested on a local instance that had previously achieved full collection. The instance was started with a build of this version, and was given a new repository to process. After a restart due to another unrelated known bug, Facade collection ran and successfully added some new aliases to the database.
@cdolfi do you think any other testing is warranted here?
Signed commits