Skip to content

feat: Make machine-exec working for che-code editor in ubi-based containers - #748

Open
RomanNikitenko wants to merge 1 commit into
che-incubator:mainfrom
RomanNikitenko:machine-exec-support-ubi-containers
Open

feat: Make machine-exec working for che-code editor in ubi-based containers#748
RomanNikitenko wants to merge 1 commit into
che-incubator:mainfrom
RomanNikitenko:machine-exec-support-ubi-containers

Conversation

@RomanNikitenko

@RomanNikitenko RomanNikitenko commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

What issues does this PR fix?

How to test this PR?

I used the following links to start a workspace and test machine-exec:

Does this PR contain changes that override default upstream Code-OSS behavior?

  • the PR contains changes in the code folder (you can skip it if your changes are placed in a che extension )
  • the corresponding items were added to the CHANGELOG.md file
  • rules for automatic git rebase were added to the .rebase folder

Summary by CodeRabbit

  • Bug Fixes
    • Improved machine-exec startup across supported architectures and runtime assemblies.
    • Updated binary placement and launch behavior to ensure the correct executable is used.
  • Chores
    • Updated the machine-exec base image to the latest build tag.
    • Simplified container initialization and removed obsolete binary setup steps.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Click here to review and test in web IDE: Contribute

Comment thread build/dockerfiles/assembly.Dockerfile Outdated
@tolusha

tolusha commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Hi! I'm che-ai-assistant — I help with your pull requests.

Available commands:

  • /che-ai-assistant generate-che-doc — Generate a documentation PR based on this PR's changes
  • /che-ai-assistant ok-pr-review — Run a comprehensive PR review (summary, code review, deep review, impact analysis)
  • /che-ai-assistant check-pr-test-failures — Analyze failing CI checks, identify root causes, and suggest fixes
  • /che-ai-assistant help — Show this help message

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

…ainers

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@RomanNikitenko
RomanNikitenko force-pushed the machine-exec-support-ubi-containers branch from 52a2b13 to 4deab86 Compare August 5, 2026 12:14
@RomanNikitenko
RomanNikitenko marked this pull request as ready for review August 5, 2026 12:14
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The Docker image now uses the next machine-exec image tag and installs binaries in architecture-specific assembly directories. The container initialization no longer prepares /checode/bin. The volume entrypoint starts ./machine-exec after selecting the runtime assembly and changing the working directory.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: azatsarynnyy, rgrunber, vitaliy-guliy


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 1 inconclusive)

Check name Status Explanation Resolution
Title check ❌ Error The title clearly describes the change and uses imperative mood, but it is 75 characters and exceeds the 72-character limit. Shorten the title to fewer than 72 characters while preserving the main change, for example: "feat: Fix machine-exec for che-code in UBI containers".
Rebase Rules For Upstream Changes ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
✅ Passed checks (3 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants