Fix get_scan_report_status field names#210
Merged
Merged
Conversation
The CxPortal SOAP GetScanReportStatus response has no `Status` field — the returned dict's `Status` key was always None. The real fields are `IsReady` and `IsFailed` (both booleans). Return those instead. Test upgrade: the existing assertion only checked IsSuccesfull, so it never caught the always-None `Status`. Assert that IsReady and IsFailed are both present and are bool — the previous code would fail this because it never populated those keys. Verified against the live SAST server (test passes in ~2s). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
cx-happy-yang
added
the
workflows-approved
|
Great job! No new security vulnerabilities introduced in this pull request |
cx-james-bostock
approved these changes
Jul 8, 2026
cx-james-bostock
left a comment
cx-james-bostock
left a comment
Contributor
There was a problem hiding this comment.
Hi @cx-happy-yang,
Looks good to me.
Contributor
Author
|
Thank you @cx-james-bostock ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CxPortal SOAP GetScanReportStatus response has no
Statusfield — the returned dict'sStatuskey was always None. The real fields areIsReadyandIsFailed(both booleans). Return those instead.Test upgrade: the existing assertion only checked IsSuccesfull, so it never caught the always-None
Status. Assert that IsReady and IsFailed are both present and are bool — the previous code would fail this because it never populated those keys.Verified against the live SAST server (test passes in ~2s).