stbridge/saf: Fix missing O_RDWR in Create() and enforce PFD modes - #215
Merged
Conversation
safFilesystem.Create() was not passing in O_RDWR, which caused it to either fail (Android 17+ with FileSystemProvider) or return a read-only safFile instance (all other scenarios). This didn't actually break anything since Create() is only used in the happy optimization path when renaming files with file versioning enabled. If it fails, Syncthing falls back to copy-and-delete. This commit also updates safNode.OpenFile() to enforce Android 17's ParcelFileDescriptor mode string restrictions so that the behavior is consistent across all Android versions. Fixes: #214 Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong
added a commit
that referenced
this pull request
Jul 29, 2026
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
safFilesystem.Create()was not passing inO_RDWR, which caused it to either fail (Android 17+ withFileSystemProvider) or return a read-onlysafFileinstance (all other scenarios). This didn't actually break anything sinceCreate()is only used in the happy optimization path when renaming files with file versioning enabled. If it fails, Syncthing falls back to copy-and-delete.This commit also updates
safNode.OpenFile()to enforce Android 17'sParcelFileDescriptormode string restrictions so that the behavior is consistent across all Android versions.Fixes: #214