Skip to content

feat: integrate geometry repair pipeline across services + docs & integration tests - #80

Open
dhimashary wants to merge 29 commits into
choras-org:devfrom
dhimashary:geometry-pipeline-integration
Open

feat: integrate geometry repair pipeline across services + docs & integration tests#80
dhimashary wants to merge 29 commits into
choras-org:devfrom
dhimashary:geometry-pipeline-integration

Conversation

@dhimashary

Copy link
Copy Markdown

Geometry Repair Pipeline – Integration

Wires the geometry inspection & repair feature together across all services,
adds the geometry-pipeline as a submodule.

Submodules

  • Added geometry-pipeline as a new submodule.
  • Bumped backend, frontend-v2, and simulation-backend pointers to the
    commits containing the repair-pipeline work.

Integration test stack

  • New docker-compose.test.yml: a self-contained stack for running the backend
    geometry-pipeline integration tests against real Docker.
    • Separate db-test Postgres (choras_test, host port 5433, tmpfs) so it
      never touches the dev database.
    • backend-test builds from the repo root, bind-mounts simulation-backend
      and tests/ for fast iteration, and runs
      pytest tests/geometry_pipeline_integration instead of the app entrypoint.
  • New .env.test with the isolated test configuration.
  • Usage documented inline (build+run, one-off run, teardown).

Documentation

  • New geometry-validation docs section under docs/source/includes/ geometry_validation/, with one page per issue type: duplicate vertices,
    zero-area faces, non-planar faces, T-junctions, self-intersections, boundary
    edges, possible holes, small faces, collinear faces, overlapping faces.
  • Added illustrative GIFs for each issue and linked the section from
    index.rst and the contribute-a-method guide.

Reviewer notes

  • ⚠️ Before merging: .gitmodules currently points several submodules to
    personal forks (dhimashary/*) and feature branches. These should be
    repointed to the choras-org repos / merged commits once the component PRs
    (backend feat/geometry-repair-pipeline, frontend feat/repair-page,
    simulation-backend geometry-pipeline-integration) are merged.
  • Depends on those three component PRs landing first.

# Conflicts:
#	backend
#	docker-compose.test.yml
#	frontend-v2
#	simulation-backend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant