Feat: Geometry pipeline integration - #32
Open
dhimashary wants to merge 12 commits into
Open
Conversation
- Add de_method/de_interface/validation.py with run_method_validation() - Add dg_method/dg_interface/validation.py with run_method_validation() (incompatible sample) - Update methods-config.json to reference validation modules for DE and DG methods
…stence and format checks
…metry compatibility issues
… in baseline geometry settings
…ds, and update Pyroomacoustics notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Geometry Compatibility & Method-Specific Validation
Introduces a declarative geometry-issue compatibility system so the platform can
tell, per simulation method, which geometry issues are acceptable or block a run.
What's new
common/.../baseline_geometry_compatibility.json):a single source of truth listing every geometry issue kind with a
label,description, and defaultcompatibilitylevel. All methods inherit this.compatible— issue doesn't affect the method; use as-is.warning— tolerated but may reduce accuracy / needs review.incompatible— breaks the method; must be repaired before running.<method>/geometry_compatibility.json) thatextendsthe baseline and override only the issue kinds that differ. Addedfor DE, DG, Pyroomacoustics, Misuka, and Sparrowpy.
validation.pyfile. It has one function,run_method_validation(input_file),that returns whether a geometry works for that method and a short reason why.
The backend loads this file at runtime using the path in
methods-config.json.Wiring (
methods-config.json)geometryCompatibility(path to the override file) andmethodValidation(path to the validation module) for DE, DG,Pyroomacoustics, Misuka, Sparrowpy.
Documentation
GEOMETRY_COMPATIBILITY_AND_VALIDATION.mdexplaining the baseline,override/merge model, compatibility levels, and how to add a method.