Adding atmospherical rendering for misuka (speed of sound, pure tone attenuation) - #34
Open
tmschnell wants to merge 2 commits into
Open
Adding atmospherical rendering for misuka (speed of sound, pure tone attenuation)#34tmschnell wants to merge 2 commits into
tmschnell wants to merge 2 commits into
Conversation
tjueterb
reviewed
Sep 2, 2026
| git init && \ | ||
| git remote add origin https://github.com/misuka-renderer/misuka.git && \ | ||
| git fetch --depth 1 origin lgpl && \ | ||
| git fetch --depth 1 origin feature/speed_of_sound && \ |
There was a problem hiding this comment.
Let me review the changes you did to misuka.
Once the changes there are final, let's create a tag instead of checking out a branch so we can guarantee consistent behavior over time.
…on my machine for test room
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds atmospherical rendering to misuka. With three new input fields for user:
Main changes:
(IR synthesis uses ether user speed of sound or computed one depending on user selection)