Skip to content

FIX: Retry misuka fetches including submodules - #37

Merged
mberz merged 4 commits into
mainfrom
fix/misuka/retry_on_git_clone
Sep 3, 2026
Merged

FIX: Retry misuka fetches including submodules#37
mberz merged 4 commits into
mainfrom
fix/misuka/retry_on_git_clone

Conversation

@mberz

@mberz mberz commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

To avoid GitHub rate limits and transient submodule failures.

Checkout submodules sequentially
Add sequential retries with increasing delays

To avoid GitHub rate limits and transient submodule failures.

Checkout submodules sequentially
Add sequential retries with increasing delays

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is small, localized to the Docker build, and the retry/sequential logic aligns with the PR goal; remaining feedback is limited to minor clarity/efficiency nits.

Pull request overview

This PR improves the reliability of building the misuka_method Docker image by making the misuka source checkout more resilient to transient GitHub fetch/submodule failures and rate-limit related flakiness.

Changes:

  • Add retry loops (up to 5 attempts) around git fetch and git submodule update, with increasing backoff delays.
  • Force submodule updates to run sequentially (--jobs 1) to reduce parallel GitHub requests.
File summaries
File Description
misuka_method/Dockerfile Adds sequentialized, retried misuka fetch + submodule update to reduce build flakiness.
Review details

Suppressed comments (1)

misuka_method/Dockerfile:70

  • Similarly, on the final submodule update attempt, the code sleeps before exiting. If attempt 5 fails, the build will still wait an extra 50s even though it will exit. Check for the last attempt before sleeping (and adjust the message accordingly).
        git submodule update --init --recursive --depth 1 --jobs 1 && break; \
        echo "submodule update failed (attempt $i/5), retrying in $((i*10))s..." >&2; \
        sleep $((i*10)); \
        [ "$i" = "5" ] && exit 1; \
  • Files reviewed: 1/1 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread misuka_method/Dockerfile Outdated
Comment thread misuka_method/Dockerfile Outdated
mberz and others added 3 commits September 3, 2026 12:58
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@mberz
mberz merged commit 1023931 into main Sep 3, 2026
22 of 24 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in CHORAS planning Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants