fix: suppress specinfra Docker finalizer warnings#75
Merged
Conversation
Unregister specinfra's backend finalizer in delete_image before manually cleaning up containers. Without this, the finalizer fires at process exit and tries to stop/delete already-removed containers, producing "warning: Exception in finalizer" noise in CI output. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
delete_imagebefore manually cleaning up containerswarning: Exception in finalizernoise seen in CI on both Ruby 3.4 and Ruby 4.0 jobsRoot cause
When
set :docker_imageis called, specinfra creates a container and registers anObjectSpacefinalizer to stop and delete it at process exit. Ourdelete_imagehelper already does that cleanup explicitly — so when the finalizer fires afterward, the containers are already gone and it raises an exception. CallingObjectSpace.undefine_finalizeron the specinfra backend instance before our cleanup prevents the double-delete.Test plan
warning: Exception in finalizerlines in the "Run tests" step🤖 Generated with Claude Code