fix(TitheFarming): use instance-aware walking for deposit sack#499
Merged
chsami merged 1 commit intoJun 25, 2026
Merged
Conversation
The depositSack() method used interactWithObject() which calculates distance using raw WorldLocation coordinates. In the instanced Tithe Farm minigame, the sack object's world coordinates are ~12500 tiles away from the player's actual position, causing the 51-tile distance check in interactWithObject() to fail and Rs2Walker.walkTo() to web-walk the character out of the minigame via teleport. Replace interactWithObject() with the same instance-safe pattern used by walkToBarrel() and coreLoop(): query the sack, check distanceTo2D against the player's actual world location, use walkMiniMap() for local movement, then click directly.
tmnlbus
force-pushed
the
fix/tithe-farm-deposit-sack-instance-coords
branch
from
95db587 to
da2a59d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
When the deposit fruit threshold is reached inside the Tithe Farm minigame, the character teleports out instead of depositing fruits into the sack.
Root Cause
depositSack()calledinteractWithObject(ObjectID.TITHE_SACK_OF_FRUIT_EMPTY, null)which uses rawWorldLocationcoordinates for its distance check. Inside the instanced Tithe Farm, the sack's world coordinates are ~12,542 tiles away from the player's actual position. This causes the 51-tile distance threshold ininteractWithObject()to fail, which then callsRs2Walker.walkTo()— a web-walker that route-plans the character out of the minigame via teleport.Logs showing the issue:
Fix
Replace
interactWithObject()with the same instance-safe pattern already used bywalkToBarrel()andcoreLoop():distanceTo2Dagainst the player's actual world locationwalkMiniMap()for local movement (stays within the instance)