Skip to content

fix: update QoL compatibility for recent RuneLite revisions#500

Open
JogOnJohn wants to merge 2 commits into
chsami:developmentfrom
JogOnJohn:fix/qol-runelite-1.12.30
Open

fix: update QoL compatibility for recent RuneLite revisions#500
JogOnJohn wants to merge 2 commits into
chsami:developmentfrom
JogOnJohn:fix/qol-runelite-1.12.30

Conversation

@JogOnJohn

@JogOnJohn JogOnJohn commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Update QoL camera access for recent RuneLite client changes.
  • Guard Wintertodt region checks during login/profile transitions so QoL does not call player-location helpers while the local player is unavailable.

Validation

  • ./gradlew.bat QoLPluginJar --console=plain
  • Local runtime smoke: QoL loads, client logs in, and the Wintertodt region check no longer produces the observed client-thread NPE during login/profile transition.

Scope

  • QoL plugin only.
  • No client/RuneLite version bump changes are included in this Hub PR.

@JogOnJohn JogOnJohn marked this pull request as ready for review June 25, 2026 00:28
@JogOnJohn JogOnJohn changed the title fix: update QoL camera access for RuneLite 1.12.30 fix: update QoL compatibility for recent RuneLite revisions Jun 25, 2026
@chsami

chsami commented Jun 25, 2026

Copy link
Copy Markdown
Owner

Not merged in this pass. The change conflicts with current development in QoLPlugin.java; please rebase/resolve the conflict and rerun the focused QoL build before merge.

@JogOnJohn JogOnJohn force-pushed the fix/qol-runelite-1.12.30 branch from fc7d710 to 196c01a Compare June 25, 2026 20:21
@JogOnJohn

Copy link
Copy Markdown
Contributor Author

Rebased the branch onto current upstream/development, resolved the QoLPlugin.java conflict, and reran the focused QoL validation.

Validation passed:

  • git diff --check upstream/development...HEAD
  • ./gradlew.bat compileQualityoflifeJava --console=plain
  • ./gradlew.bat QoLPluginJar --console=plain

The branch has been force-pushed and now reports mergeable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants