fix: restore agility mark of grace looting#501
Merged
Conversation
This was referenced Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Client#getCameraYawTarget()and bump QoLPlugin to 1.8.14, fixing the CI compile break against Microbot client 2.6.9.Root Cause
The hub agility script depended on
AgilityPlugin.getMarksOfGrace()and then reselected loot by item id through deprecatedRs2GroundItem.loot(id). That path can miss marks when the built-in Agility plugin has not populated its static list, and it can target the wrong item because it re-resolves by id instead of clicking the specific reachable mark.The PR build also exposed an unrelated existing compatibility break:
QoLPluginstill called removed client APIClient#getMapAngle(). The plugin already sets yaw throughsetCameraYawTarget(...), so readinggetCameraYawTarget()is the matching current API.Validation
./gradlew build -PpluginList=MicroAgilityPlugin -PmicrobotClientPath=/home/mimosa/IdeaProjects/microbot/Microbot/runelite-client/build/libs/microbot-2.6.7.jar./gradlew clean build -PmicrobotClientVersion=2.6.9(local Gradle still resolved the untracked local 2.6.7 jar via gradle.properties, but full compile/test/build passed)