feat: FEATURE_CFG package-overridable (config#1039)#425
Merged
Conversation
…39) — per-key override, fail-loud on unknown keys Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third gap privatized via the loader pattern (also folds the data slice of #1042's package paths): the 31 feature window/period params resolve as
{**baseline, **package_overrides}from the experiment package's data config.yamlfeature_cfg:section — searched atexperiments/$ALPHA_ENGINE_EXPERIMENT_ID/data/→ legacy → repo-local. Fail-loud guards per the no-silent-fails rule: corrupt config or unknown override key RAISES at import (a typo'd override silently reverting a window to baseline would be an invisible behavior change). 4 new tests. Suite: 1981 passed.🤖 Generated with Claude Code