Bug in String teilString = s1.substring(j, j+i);#1
Open
hermann77 wants to merge 1 commit into
Open
Conversation
Hallo, hier hat sich ein kleiner Bug eingeschlichen, wahrscheinlich wegen der verwirrenden Logik von sibstring(startIndex, endIndex), nämlich dass der Ausschnitt nicht bis zum endIndex geht, sondern bis zum (endIndex - 1): statt String teilString = s1.substring(j, j+i); müsste sein: String teilString = s1.substring(j, j+i+1); Sonst a) gehen wir am Anfang n-Mal leere Substrings durch b) das letzte Zeichen von s1 wir nie einbezogen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hallo,
hier hat sich ein kleiner Bug eingeschlichen, wahrscheinlich wegen der verwirrenden Logik von sibstring(startIndex, endIndex), nämlich dass der Ausschnitt nicht bis zum endIndex geht, sondern bis zum (endIndex - 1):
statt
String teilString = s1.substring(j, j+i);
müsste sein:
String teilString = s1.substring(j, j+i+1);
Sonst
a) gehen wir am Anfang n-Mal leere Substrings durch
b) das letzte Zeichen von s1 wir nie einbezogen