refactor(config): normalize all URL env vars via shared urlSchema - #2526
Draft
shikanime wants to merge 2 commits into
Draft
refactor(config): normalize all URL env vars via shared urlSchema#2526shikanime wants to merge 2 commits into
shikanime wants to merge 2 commits into
Conversation
shikanime
force-pushed
the
fix/gitlab-trailing-slash
branch
4 times, most recently
from
August 20, 2026 16:17
1006335 to
c7bd7f1
Compare
shikanime
force-pushed
the
fix/gitlab-trailing-slash
branch
2 times, most recently
from
August 20, 2026 16:58
c6a7910 to
84837af
Compare
shikanime
marked this pull request as ready for review
August 20, 2026 16:58
shikanime
force-pushed
the
fix/gitlab-trailing-slash
branch
from
August 20, 2026 17:17
84837af to
f56ccdf
Compare
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: I753dca17461fcc63b555334a05d98fc16a6a6964
shikanime
force-pushed
the
fix/gitlab-trailing-slash
branch
from
August 21, 2026 12:30
f56ccdf to
5d2ce7e
Compare
KepoParis
previously approved these changes
Aug 21, 2026
Replace remaining z.string().url() call sites (keycloak openid configuration, observability chart repository) with the shared normalizing urlSchema. Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: I097736ec36a7ae40641b8547b919f8d96a6a6964
shikanime
force-pushed
the
fix/gitlab-trailing-slash
branch
from
August 21, 2026 13:27
02479e8 to
81a80a3
Compare
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
shikanime
enabled auto-merge
August 21, 2026 14:00
shikanime
changed the title
StephaneTrebel
approved these changes
Aug 24, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 24, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 26, 2026
shikanime
marked this pull request as draft
August 27, 2026 13:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
Closes #2524
Quel est le comportement actuel ?
La création de groupe / sous-groupe / dépôt GitLab échoue avec une erreur
GitbeakerRequestError: Internal Server Error(HTTP 500) surPOST /api/v4/groupslorsqueGITLAB_URL(ouGITLAB_INTERNAL_URL) se termine par un slash. gitbeaker construit l'URL de base en concaténanthost + "api" + "v4"avec/, produisant…fr//api/v4(double slash) que le webservice GitLab ne route pas. Le même risque existe pour toutes les URLs injectées par variable d'environnement.Quel est le nouveau comportement ?
Une normalisation d'URL partagée (
urlSchemadansconfig.utils.ts) est appliquée à toutes les variables d'environnement de type URL des schémas de configuration :new URL(s).hrefnormalise la casse, les dot-segments et le port par défaut, puis le slash final (quenew URL()conserve) est retiré. Couvre les 17 variables URL desrc/config/(argocd, base, gitlab, harbor, keycloak, nexus, observability, service-chain, sonarqube, vault) ainsi que les champs URL hors config (configuration OpenID Keycloak, dépôt Helm observability). Les logiques locales (.replace,normalizeUrlGitLab) sont supprimées. Tests de régression ajoutés dansconfig.utils.spec.ts.Cette PR introduit-elle un breaking change ?
Non.
Autres informations
Indépendant de #2529 (collision 409 sur le nom d'utilisateur).