test(server-nestjs): parité des chemins d'erreur externes nexus/sonarqube/registry - #2583
Draft
shikanime wants to merge 3 commits into
Draft
test(server-nestjs): parité des chemins d'erreur externes nexus/sonarqube/registry#2583shikanime wants to merge 3 commits into
shikanime wants to merge 3 commits into
Conversation
…e parity Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: Iecda25d80f34897d6c421615f94040536a6a6964
…h parity Co-authored-by: Automata <automata@shikanime.studio> Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: I7a048db2689f75bd0632dd1e3c23aff16a6a6964
Open
10 tasks
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: Iaf48f76267c3288ed1801b7f70327eed6a6a6964
|
4 New Issues
0 Fixed Issues
0 Accepted Issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
#2574
Quel est le comportement actuel ?
Les specs unitaires de nexus, sonarqube et registry ne couvrent pas les chemins d'erreur des appels externes (conflit 409 à la création de dépôt, erreurs transitoires 5xx, cleanup à la suppression) tels qu'ils se présentent côté legacy.
Quel est le nouveau comportement ?
nexus.service.spec.ts: +73 lignes — 409 idempotent à l'upsert, propagation 503, cleanup au delete.sonarqube.service.spec.ts: +72 lignes — verrouillage KO→retry/propagation et suppression projet.registry.service.spec.ts: +55 lignes — conflit/conflict-upsert et nettoyage mirror.84 tests verts (10 fichiers) sur Node 24 ; aucun changement de code produit, uniquement des specs verrouillant le comportement actuel.
Cette PR introduit-elle un breaking change ?
Non.