Skip to content

fix: snapshot WebSocket subscribers before broadcast - #62

Draft
cloudcarver wants to merge 1 commit into
mainfrom
agent/security-websocket-snapshot
Draft

fix: snapshot WebSocket subscribers before broadcast#62
cloudcarver wants to merge 1 commit into
mainfrom
agent/security-websocket-snapshot

Conversation

@cloudcarver

Copy link
Copy Markdown
Owner

Summary

  • copy subscriber pointers under the hub read lock
  • broadcast text and binary messages from immutable snapshots
  • cover regular and exclusion broadcast paths
  • add concurrent subscribe, unsubscribe, and broadcast race coverage

Validation

  • go test ./...
  • go test -race ./lib/ws
  • go vet ./...

Closes #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Security] Snapshot WebSocket subscribers before broadcasting

1 participant