Seed Linear and Spotify OAuth creds in local dev - #90
Open
sizukutamago wants to merge 1 commit into
Open
Conversation
run-dev-server.js injects CLIENT_ID / CLIENT_SECRET into each OAuth gatekeeper's generated wrangler.dev.jsonc via SHARED_GATEKEEPER_CREDS, but the table covers only 8 of the 10 gatekeepers that read env.CLIENT_ID: Linear and Spotify are missing. As a result, setting LINEAR_CLIENT_ID / LINEAR_CLIENT_SECRET (or the SPOTIFY_* equivalents) in the root .dev.vars has no effect, and connecting either service in a local run always fails with the "Configuration Required" page, while the same setup works for the other eight gatekeepers. Every other OAuth gatekeeper added its own row in the same commit that introduced the package (e.g. Notion in b15cf33); the Linear and Spotify commits (d25d250, 24331ce) landed back-to-back the same day and both skipped that step, so this looks like an oversight rather than a deliberate exclusion. Verified locally: with this change the generated packages/gatekeeper-linear/wrangler.dev.jsonc contains the injected CLIENT_ID and the connect flow proceeds past the configuration check.
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
run-dev-server.jsinjectsCLIENT_ID/CLIENT_SECRETinto each OAuth gatekeeper's generatedwrangler.dev.jsoncvia theSHARED_GATEKEEPER_CREDStable, but the table covers only 8 of the 10 gatekeepers that readenv.CLIENT_ID— Linear and Spotify are missing.So in a local run (
pnpm run-local), puttingLINEAR_CLIENT_ID/LINEAR_CLIENT_SECRET(or theSPOTIFY_*equivalents) in the root.dev.varssilently does nothing, and connecting either service always lands on the "Configuration Required" page — while the identical setup works for the other eight gatekeepers.Fix
Add the two missing rows. Verified locally: after this change the generated
packages/gatekeeper-linear/wrangler.dev.jsonccontains the injectedCLIENT_ID, and the Linear connect flow proceeds past the configuration check exactly like the already-covered gatekeepers.