Add missing storage-cli S3 config parameters to blobstore templates#673
Open
kathap wants to merge 1 commit into
Open
Add missing storage-cli S3 config parameters to blobstore templates#673kathap wants to merge 1 commit into
kathap wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing storage-cli S3 config parameters to blobstore templates:
Add missing storage-cli S3 config parameters (
single_upload_threshold,request_checksum_calculation_enabled,response_checksum_calculation_enabled,uploader_request_checksum_calculation_enabled) to all blobstore JSON templates across all 5 jobs and 4 resource types.These fields allows operators to:
single_upload_threshold)All parameters are optional. If not set in the manifest, the key is omitted from the generated JSON and storage-cli applies its own defaults:
single_upload_threshold:0(always use multipart upload)request_checksum_calculation_enabled:trueresponse_checksum_calculation_enabled:trueuploader_request_checksum_calculation_enabled:trueLinks to any other associated PRs
Missing Storage CLI S3 configuration parameters #672
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run CF Acceptance Tests on bosh lite