chore(fixtures): use reserved domains and published fictional companies - #14
Merged
Conversation
The repo is public, and the fixtures paired plausible company names with plausible domains — atlasfoods.com, muse.io, kite.studio and so on. Those read as invented, but "plausible" isn't "safe": any of them may belong to someone real, and a fixture address on a live domain can actually receive mail if it's ever pasted somewhere. - Every email now sits on example.com, reserved by RFC 2606 and therefore impossible to register or route. - Company names are Microsoft's published fictional set (Contoso, Fabrikam, Woodgrove, Tailspin, Litware, Proseware, Relecloud, VanArsdel, Adventure Works, Alpine Ski House, Wide World), which exist for exactly this. They keep the shape that makes the fixtures useful — an ampersand, a long multi-word name, varied lengths — so layout still gets exercised. Northwind was already the canonical sample name and is unchanged. - Two stray UI placeholders moved to example.com as well; acme.com is a registered domain. Human contact names are untouched. They're now paired with fictional companies and unroutable addresses, so nothing links a person to a client, but say the word if you'd rather they were swapped too. Note this does NOT scrub git history — the previous values remain in every earlier commit, and on a public repo they may already be cloned, forked or cached. Removing them properly would mean rewriting history.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo is public, and the fixtures paired plausible company names with plausible domains —
atlasfoods.com,muse.io,kite.studio, nine more. They read as invented, but "plausible" isn't "safe": any of those may belong to someone real, and a fixture address on a live domain can actually receive mail if it's ever pasted somewhere.What changed
Every email now sits on
example.com, reserved by RFC 2606 and therefore impossible to register or route mail to. Two stray UI placeholders moved too —acme.comis a registered domain.Company names are Microsoft's published fictional set — Contoso, Fabrikam, Woodgrove, Tailspin, Litware, Proseware, Relecloud, VanArsdel, Adventure Works, Alpine Ski House, Wide World. They exist for exactly this purpose, so nobody mistakes one for a client.
They also keep the shape that makes the fixtures worth having: an ampersand (
Woodgrove & Co), a long multi-word name (Alpine Ski House), varied lengths. Layout still gets stressed the same way. Northwind was already the canonical sample name and is unchanged.Scope
lib/mock/*isn't read by any live screen any more — the UI moved onto the API. This is about what the public repo contains, not what it renders. The exceptions that do render areapp/portal-preview/fixtures.tsand the form placeholders, both updated; the preview harness was checked in the browser and is unaffected.Two things this does not do
It does not scrub git history. The previous values remain in every earlier commit, and on a public repo they may already be cloned, forked, or cached by GitHub. Changing HEAD only affects future readers of the current tree. Actually removing them means
git-filter-repoand a force-push, which breaks every clone and still can't reach forks or GitHub's cached views — worth doing only if any of those names were genuinely real.Human contact names are untouched — Dana Okafor, João Pereira, Ifeoma Umeh and the rest. They're now paired with fictional companies and unroutable addresses, so nothing links a person to a client. Easy to swap as well if you'd rather.
Typecheck, lint, 19 tests and build all pass locally.