security: härte XSS/SSRF + CodeQL/Dependabot-Sweep#4
Open
Musiker15 wants to merge 4 commits into
Open
Conversation
security: härte XSS/SSRF-Findings + postcss-Override - WelcomeForm: HTML-escape vor Markdown (Self-XSS in Live-Vorschau) - TicketsForm/SuggestionsForm/BackgroundDialog: img-src via safeHttpUrl() - lib/discord*.ts: assertDiscordPath() gegen SSRF (Defense-in-Depth) - postcss-Override auf ^8.5.10 (Dependabot GHSA)
security: CodeQL SSRF sanitizer + ESLint SARIF-Upload - buildDiscordUrl() ersetzt assertDiscordPath: URL-Constructor mit fixed base + Deny-List am fetch-Sink → CodeQL-erkennbar - ESLint-Workflow lädt jetzt SARIF zu Code Scanning hoch → stale Alerts schließen automatisch beim nächsten Push
GitHub Code Scanning ignoriert SARIF-`suppressions[]` mit leerer Justification — alle `/* eslint-disable-next-line */`-Treffer landeten trotzdem als „offene Alerts" im Security-Tab. jq-Step entfernt sie vor dem Upload. Zusätzlich upload-sarif@v3 → @v4 (Deprecation). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
components/WelcomeForm.tsx: HTML-escape vor Markdown→ schließt Self-XSS in der Live-Vorschau
via neuem
lib/safeUrl.ts(safeHttpUrl()lässt nur http(s) durch)lib/discord.ts+lib/discordBot.ts:buildDiscordUrl()mit URL-Constructor + fixed base + Deny-ListpostcssOverride auf^8.5.10(GHSA-XSS)Test plan
npx eslint .→ exit 0npx tsc --noEmit→ exit 0