Fix buzzer control on newer Gree firmwares - #162
Open
thibaulf wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #162 +/- ##
=======================================
Coverage 95.71% 95.71%
=======================================
Files 8 8
Lines 770 771 +1
=======================================
+ Hits 737 738 +1
Misses 33 33 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
thibaulf
force-pushed
the
master
branch
2 times, most recently
from
June 11, 2026 23:08
ac4c549 to
e61c2bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer firmware versions utilize BuzzerCtrl instead of Buzzer_ON_OFF to manage buzzer behavior. Note that the control logic between the two parameters is inverted: