Fix handling of mixed-case bindOk responses - #172
Open
youssef-idrees wants to merge 1 commit into
Open
Conversation
youssef-idrees
marked this pull request as ready for review
July 15, 2026 20:15
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #172 +/- ##
==========================================
+ Coverage 95.71% 95.72% +0.01%
==========================================
Files 8 8
Lines 770 772 +2
==========================================
+ Hits 737 739 +2
Misses 33 33 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some Gree devices return the bind response type as
bindOkinstead of the expected lowercasebindok.The response is otherwise valid and includes
r: 200and the encryption key, but the case-sensitive packet-type lookup treats it as an unknown packet. This causes binding to time out even though the device replied successfully.This change normalizes the
bindOkresponse to the existingbindokvalue before dispatching it.Example response
{ "t": "pack", "i": 1, "uid": 0, "cid": "REDACTED", "tcid": "", "pack": { "t": "bindOk", "mac": "REDACTED", "r": 200, "key": "REDACTED" } }