fix: preserve OpenAPI query names and omitted defaults - #95
Conversation
bc678d1 to
7388bd0
Compare
|
Published repair commit 4d5ab46. This update keeps explicit false values working while preventing omitted optional booleans from overriding API defaults. It also repairs the stale Petstore fixture path and makes the CLI smoke test invoke the real generate-mcp subcommand. Validation: 25 generator tests passed, Ruff passed, JSON parsing passed, Python compilation passed, and the diff checks are clean. No unresolved review feedback remains. |
|
Maintainer action needed: GitHub has held all 4 repository workflows for approval because this PR comes from a fork. Each run is I reproduced the contributor-side checks at head The repository-wide Ruff command still reports the existing upstream baseline; the latest |
Signed-off-by: Burak <8755484+kriptoburak@users.noreply.github.com>
4d5ab46 to
873e9b0
Compare
|
Repair consolidated in GitHub-verified signed commit
Validation on Python 3.13: 25 tests passed, changed Python files pass Ruff, JSON parsing passed, Python compilation passed, and The 4 fork workflows still require maintainer approval and created zero jobs: Please approve the fork workflows when convenient. Xquik is an independent third-party service. Not affiliated with X Corp. "Twitter" and "X" are trademarks of X Corp. |
Summary
Independent Repository Fixes
The optional boolean generator previously defaulted omitted values to false. Generated clients therefore sent false even when callers omitted the parameter, overriding API defaults. Optional booleans now default to None and are transmitted only when supplied.
The existing generator tests also referenced a missing Petstore filename and invoked the command function as though it were the CLI group. Both tests now exercise the tracked fixture and public subcommand.
Validation
I maintain Xquik. Xquik is an independent third-party service. Not affiliated with X Corp. "Twitter" and "X" are trademarks of X Corp.