fix(stream): preserve structured error codes across operations - #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stale Stream APPEND and COMMIT failures previously omitted numeric domain codes. Encode non-READ errors as status 2 plus the code and message, preserving READ and success layouts. Apply the same envelope to ingress and subscription failures.
Related to #238. The issue remains open for coordinated publication and released-artifact qualification. Updated clients must precede the broker rollout; this PR does not publish packages or images.
Validation: Full Rust workspace: 2,192 passed, one existing ignored benchmark-artifact test. Formatting, strict Clippy, docs validation, and module-size policy pass. Includes 93 Stream transport and five wire-contract cases.
AI assistance: Codex assisted implementation, regression tests, migration documentation, and review of the wire/consumer contract. The change was reviewed against source and validated with the checks above.