Preserve personal request access and exact recording choices for companion apps - #1
Draft
cocoHMC wants to merge 12 commits into
Draft
Preserve personal request access and exact recording choices for companion apps#1cocoHMC wants to merge 12 commits into
cocoHMC wants to merge 12 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The metadata connection blocker is resolved in the deployed server. Controlled same-container tests isolated failures to outbound application identification. A truthful, configurable integration identifier restores MusicBrainz/ListenBrainz access while preserving TLS, VPN routing and rate limits. The formerly failing exact-song request now returns success with a durable, identity-verified acquisition task. 780 regression tests pass. See recovery evidence; queued is not claimed as imported audio.
Tonarr companion requests need personal, revocable access and must preserve exactly what each listener requested. This adds companion device sessions, listener-specific shared request history, approval-safe song requests, and verified clean-edition acquisition without silently substituting an original recording.
Track requests now carry
content_variantthrough persistence, approval, retry and dispatch; this fixes the liveunexpected keyword argumentfailure. MusicBrainz network failures remain temporary service errors instead of being reported as missing editions. The branch also contains the companion-session replacement, outbound User-Agent and AudioDB enrichment fixes used by this deployment.Validation: 196 focused request/history/approval tests passed for the content-variant fix. The catalog-error change passed 703 tests in the broader repository/acquisition run; its one outdated missing-edition expectation was updated and all 60 focused regression tests then passed. The deployed immutable image is
local/droppedneedle:b6ed04a, health is healthy, and its changed source file hash matches the pushed commit.Live Tonarr iOS and LG requests exposed a remaining environment issue: MusicBrainz and ListenBrainz TLS connections fail from the server, while a control HTTPS endpoint succeeds. Exact-song acquisition is therefore not yet proven end to end; no verification checks were disabled and the planned 100-song batch was deferred. This PR does not claim downloads succeeded or change the owner's acquisition sources, approvals or quotas.