feat: denial of device link requests#25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Server and client now support
FAITH_ENVELOPE_DEVICE_AUTH_DENY. The server now handles responses to device link requests by using one centralizedserver_handle_device_link_responsefunction for both DENY and APPROVE envelopes. This function is enabled by the renaming offaith_client_device_link_approval_ttofaith_client_device_link_response_twhich now handles both denial and approval responses to a device link request.Testing
Describe how you tested this change.
scripts/check.shpasses locally