feat(tipping): Tips tab + tip card flow (scaffold) - #1121
Merged
Conversation
- Reorganize bills: RenderedBill -> ScannableRenderer, AnimatedBill ->
AnimatedScannable, composables into components/{bills,cards,receipts}
(adds the TipCard renderer); BillContainerView -> ScannableContainer.
- Widen BillState.bill to Scannable? and add SessionController.showTipCard so a
non-payment tip card can be presented in the container (no grab/valuation);
add tip SessionState fields wired to the new Tipping feature flag.
- Theme: add the tipCard color token; bump the xxl corner shape.
- Incidental: enable Gradle parallel tooling; small ResolverService refactor.
- Add the tipping feature module: TippingFlowScreen + TipFlowViewModel + screens (TipCard, Tips, TipInfo); the tip card is built via TippingCoordinator. - Add core tipping flow steps (TipStep/TipResult) and tip-hand drawables. - Wire the Tips tab into navigation (AppRoute, NavBarButton, NavigationBar, ScannerDecorItem/ScannerNavigationBar), gated on the Tipping feature flag. Scaffold only — scanning tip cards, the tip payment modal, tip chats, and blur hashes are follow-ups.
bmc08gt
added a commit
that referenced
this pull request
Jul 24, 2026
* refactor(scannable): render Scannables through the bill container
- Reorganize bills: RenderedBill -> ScannableRenderer, AnimatedBill ->
AnimatedScannable, composables into components/{bills,cards,receipts}
(adds the TipCard renderer); BillContainerView -> ScannableContainer.
- Widen BillState.bill to Scannable? and add SessionController.showTipCard so a
non-payment tip card can be presented in the container (no grab/valuation);
add tip SessionState fields wired to the new Tipping feature flag.
- Theme: add the tipCard color token; bump the xxl corner shape.
- Incidental: enable Gradle parallel tooling; small ResolverService refactor.
* feat(tipping): tip card flow, Tips tab, tip chats scaffold
- Add the tipping feature module: TippingFlowScreen + TipFlowViewModel + screens
(TipCard, Tips, TipInfo); the tip card is built via TippingCoordinator.
- Add core tipping flow steps (TipStep/TipResult) and tip-hand drawables.
- Wire the Tips tab into navigation (AppRoute, NavBarButton, NavigationBar,
ScannerDecorItem/ScannerNavigationBar), gated on the Tipping feature flag.
Scaffold only — scanning tip cards, the tip payment modal, tip chats, and blur
hashes are follow-ups.
bmc08gt
added a commit
that referenced
this pull request
Jul 27, 2026
… order (#1157) Users who customized their nav bar order before Tips was added to the NavBarButton enum (#1121) had a persisted order string without Tips. NavBarConfig.deserialize only fell back to defaultOrder on an empty list, so it reconstructed the stored order verbatim, missing Tips. The scanner nav bar filter can only remove buttons, never add them, so enabling the tipping beta flag never surfaced the Tips tab on those devices. deserialize now merges any button missing from the persisted order, inserting each at its position in defaultOrder. Self-heals affected devices on next launch with no migration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tipping feature scaffold: the Tips tab, tip-card flow, and tip-chats list.
Changes
features/tippingmodule:TippingFlowScreen+TipFlowViewModel+ screens (TipCard, Tips, TipInfo). The user's own tip card is built viaTippingCoordinator.resolveTipCard()and rendered throughScannableRenderer; the Tips list surfaces tip-DM conversations.TipStep/TipResult, plus the tip-hand drawables.AppRoute,NavBarButton,NavigationBar, and the scanner nav (ScannerDecorItem/ScannerNavigationBar), gated on theTippingfeature flag.Scope
Scaffold only. Deliberately not in this PR (follow-ups): scanning tip cards + the tip payment modal, full tip chats, blur hashes, and the share-tip-card flow (share controller / Linkify).
Testing
./gradlew :apps:flipcash:app:assembleDebug— BUILD SUCCESSFUL (stack of #1120 + this).