test(session): fix SessionController unit test compilation (tippingDelegate) - #1129
Merged
Conversation
RealSessionController gained a required tippingDelegate: TipCardDelegate constructor parameter (tip card resolution/presentation), but the two SessionController unit tests still constructed it without that argument, breaking :apps:flipcash:shared:session:compileDebugUnitTestKotlin and the overall test build. Pass a relaxed mock, matching the other delegates.
github-actions
Bot
added
area: session
type: test
bmc08gt
added a commit
that referenced
this pull request
Jul 24, 2026
…1129) RealSessionController gained a required tippingDelegate: TipCardDelegate constructor parameter (tip card resolution/presentation), but the two SessionController unit tests still constructed it without that argument, breaking :apps:flipcash:shared:session:compileDebugUnitTestKotlin and the overall test build. Pass a relaxed mock, matching the other delegates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the required
tippingDelegateargument to the twoRealSessionControllerconstruction sites in the session module's unit tests.Why
RealSessionControllergained a required constructor parametertippingDelegate: TipCardDelegate(tip card resolution/presentation), butSessionControllerEventRoutingTestandSessionControllerGiftCardErrorTeststill constructed it without that argument. This broke:apps:flipcash:shared:session:compileDebugUnitTestKotlin, which failed the whole./gradlew testbuild:Fix
Pass
tippingDelegate = mockk(relaxed = true), matching how the other delegates (depositDelegate, etc.) are supplied in these tests.Testing
./gradlew :apps:flipcash:shared:session:testDebugUnitTest— passes./gradlew test --continue— BUILD SUCCESSFUL (no remaining failures)