Skip to content

chore(tips): remove profile photo from tip card setup for now #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
Jul 27, 2026
Merged

chore(tips): remove profile photo from tip card setup for now #1160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...sh/features/tipping/src/main/kotlin/com/flipcash/app/tipping/internal/TipFlowViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ internal class TipFlowViewModel @Inject constructor(
stateFlow.map { it.resumed }.distinctUntilChanged(),
) { profile, resumed ->
buildList {
val hasProfile = profile?.displayName != null && profile.profilePicture != null
val hasProfile = profile?.displayName != null // TODO: explicitly not required right now && profile.profilePicture != null
when {
// Post-setup handoff: land on TipCard alone, with a close affordance. No Tips
// underneath — closing exits, and reopening from home lands on the Tips list.
Expand Down
2 changes: 1 addition & 1 deletion ...atures/tipping/src/main/kotlin/com/flipcash/app/tipping/internal/screens/TipInfoScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ internal fun TipInfoScreen() {
AppRoute.UpdateUserProfile(
origin = AppRoute.Sheets.Tips(),
includeName = userManager?.profile?.displayName.isNullOrEmpty(),
includePhoto = userManager?.profile?.profilePicture == null,
includePhoto = false, // explicity false for now
target = AppRoute.Sheets.Tips(resumed = true),
)
)
Expand Down
Loading