fix(tips): optically center share icon in tip card button - #1164
Merged
Conversation
The ic_remote_send glyph is bottom-heavy (a wide upload tray beneath a thin arrow), so geometric centering inside CircularIconButton leaves it sitting visually low in the circle. Nudge the icon up ~1.5dp at the tip card call site to optically center it, without touching the shared drawable used elsewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The share icon button on the Tip Card screen renders its icon visually low in the circle.
The
CircularIconButtoncontainer centers the icon's canvas correctly — the off-centering comes from theic_remote_senddrawable itself. Within its 28×28 viewport the glyph is bottom-heavy: a wide upload tray sits beneath a thin up-arrow, putting the stroke centroid ~10% below the viewport center. Geometric centering therefore leaves it looking like it sits toward the bottom of the circle.Fix
Nudge the icon up ~1.5dp at the Tip Card call site to optically center it. The shared
ic_remote_senddrawable is untouched, so its other usages (TitleBar,BillState) are unaffected.Notes