fix(ui): restore BottomBar padding after Modal migration - #1170
Merged
Conversation
PR #1128 migrated BottomBarContainer to the shared Modal composable but inherited Modal's own layout defaults, changing how the bar renders: - top inset padding was halved (inset -> grid.x2) - an extra bottom gap was added (grid.x2, on top of the button's own padding) - item spacing tightened (grid.x3 -> grid.x2) - title/subtitle became center-aligned instead of start-aligned Parameterize Modal with contentPadding and horizontalAlignment (defaults unchanged, so other callers like ReceivedFundsConfirmation are unaffected) and pass the original BottomBarView values from BottomBarContainer.
github-actions
Bot
added
type: fix
… visible The manager clears the active message immediately on close (so other screens don't re-show it), which set bottomBarMessage to null before the AnimatedContent exit transition finished. BottomBarView early-returns on a null message, so the outgoing frame rendered nothing and the bar appeared to vanish instantly instead of sliding out. Retain the last non-null message and render that during the transition so the slide-out animation is visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #1128 (
chore(ui): have BottomBarContainer render using Modal) switchedBottomBarContainerto the sharedModalcomposable. Because the old inlineColumnandModalhave different layout opinions, the bottom bar no longer renders the way it did before — most visibly in its padding and alignment.Concrete differences it picked up from
Modal's defaults (example values for the NORMAL width class:inset=20,grid.x2=10,grid.x3=15):Columninset(20)grid.x2(10) — halvedgrid.x2(10) — extra gap on top of the last button's own bottom paddinggrid.x3(15)grid.x2(10) — tighterFix
Modal's centered, symmetric-padding defaults are correct for its other caller (ReceivedFundsConfirmation), so rather than change the defaults:Modalgains two params —contentPadding: PaddingValuesandhorizontalAlignment: Alignment.Horizontal— whose defaults exactly match the previous hard-coded values, so all existing callers are unaffected.BottomBarContainerpasses the originalBottomBarViewlayout values: top/horizontal-onlyinsetpadding,Alignment.Start, andgrid.x3item spacing.Testing
./gradlew :ui:components:compileDebugKotlincompiles clean.Modalcaller (ReceivedFundsConfirmation) usesModal {}with no layout args → keeps unchanged defaults.Typography
Also aligns the bar's text styles with the design:
textMedium(16sp) →textLarge(20sp SemiBold)textSmall(14sp) →caption(12sp Medium)Exit animation
While verifying, the BottomBar's slide-out (exit) animation was missing — dismissing a modal made it vanish instantly instead of sliding down. Cause:
BottomBarManager.setMessageShown(id)clears the active message immediately on close (so other screens don't re-show it), settingbottomBarMessagetonullbefore theAnimatedContentexit transition completes.BottomBarViewearly-returns on a null message, so the outgoing frame rendered nothing.Fix: retain the last non-null message and render it during the transition, so the outgoing content stays on screen to animate out. Verified with Maestro (Menu → My Account → Log Out → Cancel) by recording the dismissal — the modal now slides down and off-screen over several frames rather than disappearing in one.