fix(tipping): tip card layout, sizing, and color - #1175
Merged
Conversation
Lift the 'Share Your Tip Card' subtitle into the top bar and vertically center the tip card so it sits evenly in the available space (and trim its width).
- Render the My Tip Card opaque at the design's flattened color (#101011)
instead of a translucent fill that multiplied the app's Brand background and
read too dark/purple.
- Use Figma's proportions (TipCardAspectRatio = 333/269) and cap the card width
at 270dp.
- Show a single 'Tip {name}' label (ellipsized, 2 lines).
github-actions
Bot
added
the
area: payments
bmc08gt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polish for the My Tip Card screen (and the shared tip-card component), extracted from the chat-profile branch to PR on its own.
Changes
#101011(rgb(16,16,17)). The previous translucent fill (36% black) multiplied the app's purpleBrandbackground and read too dark/purple; the card is a static display with nothing behind it, so it's now solid.TipCardAspectRatio = 333/269and cap the card width at270dp(the old1.16was iOS-parity but out of spec).Tip {name}label (ellipsized, up to 2 lines).Testing
./gradlew :apps:flipcash:app:assembleDebug— green.