fix(messenger): dismiss keyboard before send/navigation - #1176
Merged
Conversation
Dismiss the soft keyboard first when tapping the send-cash ($) button and when navigating away from the conversation, so the insufficient-balance alert (and the destination screen) aren't hidden behind the keyboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the message bar is pulled up and you tap the send-cash ($) button without a balance, the keyboard was covering the insufficient-balance alert. Now the keyboard is dismissed first (via
keyboard.hideIfVisible { … }) on the $ button and when navigating away from the conversation, so the alert / destination screen is visible.Extracted from the chat-profile branch to PR on its own.
Testing
:apps:flipcash:features:messenger:compileDebugKotlin— green.