Skip to content

test(auth): fix AuthManager onboarding-resume tests for display-name gate #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
Aug 5, 2026
+30 −0
Merged

test(auth): fix AuthManager onboarding-resume tests for display-name gate #1185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions apps/flipcash/shared/authentication/src/test/kotlin/com/flipcash/app/auth/AuthManagerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import com.flipcash.services.controllers.AccountController
import com.flipcash.services.controllers.ProfileController
import com.flipcash.services.controllers.PushController
import com.flipcash.services.models.UserFlags
import com.flipcash.services.models.UserProfile
import com.flipcash.services.user.AuthState
import com.flipcash.services.user.UserManager
import io.mockk.coEvery
Expand Down Expand Up @@ -75,6 +76,11 @@ class AuthManagerTest {
Dispatchers.setMain(testDispatcher)

every { userManager.state } returns userManagerState
// Default to a profile that already has a display name so onboarding resume falls through
// to the post-access-key path. Tests exercising the DisplayName step override this.
every { userManager.profile } returns mockk<UserProfile>(relaxed = true) {
every { displayName } returns "Test User"
}
every { networkConnectivityListener.isConnected } returns true
coEvery { pushTokenProvider.getToken() } returns "fake-token"

Expand Down Expand Up @@ -288,6 +294,30 @@ class AuthManagerTest {
verify { userManager.set(AuthState.Onboarding(AuthState.ResumePoint.PostAccessKey)) }
}

@Test
fun `login resumes at DisplayName when access key seen but no display name set`() = runTest {
val entropy = "dGVzdGVudHJvcHkxMjM0NQ=="
val accountMetadata: AccountMetadata = mockk(relaxed = true)
val testId = listOf<Byte>(1, 2, 3)
every { accountMetadata.id } returns testId

coEvery { credentialManager.login(entropy, any()) } returns Result.success(accountMetadata)
coEvery { credentialManager.hasCompletedOnboarding() } returns false
// Access key seen, registered, but the display name hasn't been set yet.
every { userManager.profile } returns mockk<UserProfile>(relaxed = true) {
every { displayName } returns ""
}

val flags = UserFlags.Default.copy(isRegistered = true)
coEvery { accountController.getUserFlags() } returns Result.success(flags)

val result = authManager.login(entropyB64 = entropy)

assertTrue(result.isSuccess)
verify { userManager.set(flags) }
verify { userManager.set(AuthState.Onboarding(AuthState.ResumePoint.DisplayName)) }
}

@Test
fun `login falls back to Ready when flags exhausted but onboarding completed`() = runTest {
val entropy = "dGVzdGVudHJvcHkxMjM0NQ=="
Expand Down
Loading