chore(tips): remove profile photo from tip card setup for now - #522
Merged
Conversation
Skip the photo-capture step in tip card setup (name -> card directly) and gate the card's avatar behind an includePhoto flag defaulting to off, so no tip card surface (My Tip Card screen or scanned recipient card) renders the profile photo for now. Mirrors Android #1160. The avatar rendering and load paths are kept behind the flag so re-enabling is a one-line change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports Android #1160 to iOS.
What & why
Remove the profile photo from tip card setup for now.
ProfileNameScreenpushes.tipcardinstead of.profilePhoto).ProfilePhotoScreenand the.profilePhotoroute are left in place for easy re-enable.includePhotoflag onTipcardView, defaulting tofalse. Both surfaces that build the card (My Tip Card screen and the scanned recipient card inBillCanvas) use the default, so no tip card renders a photo. This mirrors Android, where the card'sincludePhotoparam defaults false and no caller enables it.The avatar rendering and load paths are kept behind the flag, so restoring the photo later is a one-line change.
Testing
Flipcashapp scheme compiles clean (iPhone 16 Pro sim).