feat(tips): use the minimized send button only in tip chats - #525
Merged
Conversation
Tip chats now always show the compact, symbol-only glass send button instead of the expanded "Send $" pill. Added an alwaysMinimized flag on SendCashMorphButton, folded into a minimized computed (composing || alwaysMinimized) that the whole morph keys off, and threaded isTipDm (tipCounterpart != nil) down from ConversationScreen. Ordinary chats are unchanged — expanded at rest, collapsing to the symbol only while composing. Mirrors Android #1165.
bmc08gt
added a commit
that referenced
this pull request
Jul 27, 2026
…el (#523) * fix(tips): pad tip code payload reserved bytes with a non-zero sentinel The tip payload left the reserved trailing bytes (17-19) zero. KikCodes.decode strips trailing zero bytes, so a frame whose reserved region (or user id tail) is zero comes back short. Fill the reserved region with incrementing digits (1, 2, 3) on encode so the frame always ends non-zero and round-trips at full length. Decoding still re-pads for legacy zero-trailing frames. Mirrors Android #1163. * fix(chat): restore dropped comma when merging code/main into the tip payload branch The #524 (focusOnAppear) and #525 (isTipDm) conversation-bar params were integrated on main without a separator between them, leaving ConversationScreen and ChatScreenRepresentable non-compiling. Add the missing commas so the tree builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports Android #1165 (part 3) to iOS.
What & why
Tip chats now always show the compact, symbol-only glass send button instead of the expanded "Send €" pill. Normal chats are unchanged — expanded at rest, collapsing to the symbol only while composing.
SendCashMorphButtongains analwaysMinimizedflag, folded into aminimizedcomputed (composing || alwaysMinimized) that the whole morph (label, fill, width, color) keys off.isTipDmthreads down fromConversationScreen(reusing the existingtipCounterpart != nil/.tipDmsignal) throughChatScreenRepresentableto the bar.Testing
Flipcashapp scheme compiles clean (iPhone 16 Pro sim).