feat(onboarding): collect display name in place of phone verification - #547
Merged
Conversation
Replace the onboarding phone-verification step with a mandatory display-name step, mirroring the Android change (code-android-app#1183). Onboarding is now: create account → access key → name → permissions. - Drop phone verification from onboarding. The phone screens and PhoneVerificationViewModel stay intact (still used by the post-login Send sheet and the Onramp flow); only the onboarding entry point changes. This also retires the vestigial `enablePhoneNumberSend` gate — phone verification existed to power phone-number Send, which was removed in #546. - Add OnboardingNameViewModel + OnboardingNameScreen: a pre-login name step that reuses DisplayNameValidator and SetDisplayName against the in-flight owner. The tip-card ProfileNameScreen can't be reused as-is because it is session-scoped (SessionContainer / AppRouter); this mirrors how the onboarding phone step wrapped its own view model. - The name step is mandatory: the navigationDestination hides the back button, so a new account always has a name for tips and chat. - Update the create-account UI smoke helpers (enterDisplayNameIfNeeded) and add OnboardingNameViewModel unit tests.
bmc08gt
force-pushed
the
feat/onboarding-display-name
branch
from
August 5, 2026 19:33
925de9a to
3ed0d0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ports the Android onboarding change (code-android-app#1183) to iOS: replaces the phone-verification step in onboarding with a mandatory display-name step. Onboarding is now ordered:
Why
We want onboarding to capture a display name (used for tip cards, chat, etc.). The iOS phone step existed solely to power phone-number Send, which was removed in #546 — so the step was vestigial. Replacing it with display-name collection is the natural follow-through now that Tips is the default.
How
EnterPhoneScreen/ConfirmPhoneScreen/PhoneVerificationViewModelare untouched — they're still used by the post-login Send sheet and the Onramp flow. Only onboarding's entry point changes: the.phoneVerification/.confirmPhoneNumberCodeOnboardingPathcases and theenablePhoneNumberSendgate are gone.OnboardingNameViewModel+OnboardingNameScreencollect the name pre-login, reusingDisplayNameValidatorandSetDisplayNameagainst the in-flight owner keypair. The tip-cardProfileNameScreencan't be reused as-is (it's session-scoped:SessionContainer/AppRouter), so this mirrors how the onboarding phone step wrapped its own view model.navigationDestinationhides the back button, so a new account always has a name before reaching the app.Testing
build-for-testingcompiles all test targets.OnboardingNameViewModelTests(validation-state coverage) — 3 passing.enterDisplayNameIfNeededreplacesallowPhoneVerificationIfNeededon the onboarding path) acrossCreateAccount,CurrencySelection,DiscoverCurrencies,Give, andcreateFreshAccount.