fix(coding-agent): pause stale goals on direct input - #553
Open
realsigridjin wants to merge 2 commits into
Open
Conversation
Migrate legacy pi-goal state before session initialization while keeping current-store precedence and current token-budget metadata intact.
Give newer interactive and RPC input precedence over active durable goals while preserving extension continuation, in-flight accounting, and explicit lifecycle controls. Related to code-yeongyu#447.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
userGracecontinuation path while preserving extension-originated and unattended monitor continuationpi-goalstate before session initialization without changing current-store precedence ortokenBudgetround tripsRoot cause
Direct input did not create another session. A stale active goal remained eligible for a hidden delayed continuation after the user had moved on, making the terminal appear to switch back to another task.
Behavior changes
active -> pausedbefore the new turnagent_endwith a goal-id guard/goal resumeVerification
npm run checknpm run checkpassed on the final treenpm run buildpassedtokenBudgetregressionRisk boundaries
Related to #447.
Summary by cubic
Pause active goals on direct interactive/RPC input to prevent stale hidden continuations; remove the 60s “userGrace” timer and keep monitor-delayed continuation intact. Also migrate legacy
pi-goalfiles into the currentgoalstore at session start. Fixes #447.Bug Fixes
active -> pausedat the input seam; the new turn isn’t charged to the goal.agent_endafter usage is accounted./goal resumeto reactivate.Migration
extensions/pi-goal/<threadId>.jsontoextensions/goal/<threadId>.json.tokenBudgetand normalizebudgetLimitedtoactive; existing current-store files always win.tokenBudgetmetadata (if present) is preserved on read/write.Written for commit 92af158. Summary will update on new commits.