[pull] master from cube-js:master - #678
Merged
Merged
Conversation
…11597) * docs(monitoring): document log fields and metric labels (CUB-2879) Monitoring Integrations documented inputs, sinks and metric names but nothing about the tags attached to what actually gets exported. Add, from the code: - the fields attached to every exported log record (deployment_id, deployment_name, hostname, pod_name, service, level, status, origin), plus the Datadog-only ddsource/ddtags and the per-sink `ddtags` option; - the Prometheus labels on exported metrics (pod_name on cpu/memory, deployment_id/api_type/request_source on cube_requests_*), which is what gives a per-API request and latency breakdown; - query_history_link in the Query History export field table, and a note that Query History records carry a different field set than container logs. * docs(monitoring): address review — ddtags defaults in prose, trim example (CUB-2879) - describe the ddtags defaults in prose instead of $DEPLOYMENT_NAME,$HOSTNAME, which read as user-settable env vars next to the CUBE_CLOUD_MONITORING_* section above; - trim the third near-identical [sinks.datadog] block to the new option only; - note on the `service` row that query-history records use a fifth value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )