[pull] master from jitsi:master - #834
Merged
Merged
Conversation
…open (#17724) WebRTC's NetworkMonitorAutoDetect already calls ConnectivityManager#requestNetwork for TRANSPORT_CELLULAR on its own, to keep the mobile data interface up even while wifi is the active network. That call needs CHANGE_NETWORK_STATE, and jitsi-meet never declared it, so the call has been throwing SecurityException, caught and logged by WebRTC, ever since. Without a cellular interface up, WebRTC gathers only one ICE candidate for a JVB session (whichever transport wifi/cellular happens to be active), so only one candidate pair ever forms. A bridge running keep-alive-strategy = all_succeeded has nothing to fail over to, and losing wifi means recovering from a torn-down session rather than switching to an already-established path. CHANGE_NETWORK_STATE is protection level normal, so it is granted at install time with no runtime prompt and no user-facing change. Measured on a Pixel against a single bridge, wifi disabled mid-call: before 17.35 s of no media, recovered by a full session restart after ~1.2 s of no media, recovered by WebRTC's own pair switch Reconnecting to wifi measured no gap above 0.3 s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )