[pull] master from jitsi:master - #840
Merged
Merged
Conversation
…#17740) on_breakout_room_pre_create destroyed the room and returned true without a reply when the breakout room was not registered in the main room. The join presence of the client got no answer, so the client waited until its own timeout. Prosody sends an error of its own for restrict_room_creation, but that handler and this one both use the default priority on muc-room-pre-create. util.events builds the handler list from a table keyed by the handler function, then sorts by priority only, and the sort is not stable. The order of the two handlers is therefore not defined, and it can differ for each prosody process. This made the integration test 'non-admin cannot create rooms on the breakout component' fail in 11 of 20 local runs. With this change it passed 20 of 20 runs.
* fix: iframe pip with redux as source of truth * fix: hardcoded version * fix: broken rebase * updated changes * updates * updates * config guard * fix: ci failures * achitectural update * updates * updates * suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )