[pull] master from mattermost:master - #922
Merged
Merged
Conversation
* Fix plugin settings section handling Co-authored-by: ben.schumacher <ben.schumacher@mattermost.com> * Handle failed plugin activation in settings Co-authored-by: ben.schumacher <ben.schumacher@mattermost.com> * Process settings across schema sections Co-authored-by: ben.schumacher <ben.schumacher@mattermost.com> * Render mixed settings schema content Co-authored-by: ben.schumacher <ben.schumacher@mattermost.com> * Strengthen mixed schema rendering test Co-authored-by: ben.schumacher <ben.schumacher@mattermost.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>
…37970) * [MM-70252] Reject malformed date filters in logs query API The POST /api/v4/logs/query endpoint parsed date_from/date_to with a fixed layout and swallowed parse errors, silently dropping the bound instead of signalling the caller. A malformed date_from became the zero time and a malformed date_to became now, so the request returned HTTP 200 with an unfiltered result set. Add LogFilter.IsValid, which rejects a non-empty bound that cannot be parsed with the shared LogFilterDateLayout while keeping empty strings meaning "unbounded", and call it from queryLogs so a bad filter returns 400 naming the offending field and the expected layout. Co-authored-by: mattermost-code <matty-code@mattermost.com> * [MM-70252] Add tests for logs query date filter validation Add a unit test for LogFilter.IsValid covering empty (unbounded), valid, and malformed bounds, and an api4 integration test that drives POST /logs/query through the real router to assert malformed date_from/date_to return 400 with the offending field id while empty and valid bounds return 200. Co-authored-by: mattermost-code <matty-code@mattermost.com> * [MM-70252] Harden logs query date filter tests Address test-quality review: exercise the DateTo validation branch with a valid non-empty DateFrom, move fallible checks out of the require.Eventually condition to avoid a cross-goroutine failure, and make each api4 subtest self-contained by polling for the expected messages via a shared helper so valid-bounds also verifies filtering still returns records. Co-authored-by: mattermost-code <matty-code@mattermost.com> * [MM-70252] Retrigger CI/CodeRabbit after invalid public-module feedback Co-authored-by: mattermost-code <matty-code@mattermost.com> * [MM-70252] Note shared LogFilterDateLayout usage in date filter Co-authored-by: mattermost-code <matty-code@mattermost.com> * [MM-70252] Add Client4.QueryLogs to simplify logs query date filter tests * Address PR feedback: 2 answered, 1 resolved, 0 declined --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: mattermost-code <matty-code@mattermost.com> Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
* ci: bump test-system-io-summary action for missed-spec status Placeholder bump pending merge of mattermost-test-system-io summary fix. Co-authored-by: saturnino <saturnino@mattermost.com> * ci: re-pin test-system-io-summary to main e2d5032 Replace the pre-merge placeholder SHA with the latest mattermost-test-system-io main commit, which includes the squash-merged missed-spec summary fix from #96. Co-authored-by: saturnino <saturnino@mattermost.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: saturnino <saturnino@mattermost.com> Co-authored-by: Mattermost Build <build@mattermost.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )